Ngee arctic im4/pft physiology #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsulman
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
from
2f99988 to
d519db7
Compare
fmyuan
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
4 times, most recently
from
a7cfe78 to
d7b1b4b
Compare
fmyuan
reviewed
Feb 23, 2024
fmyuan
left a comment
fmyuan
left a comment
There was a problem hiding this comment.
Comments out code changes for layers below last soil layer, i.e. bedrock layers. This will fix 2 previous variable soil thickness test failures.
thorntonpe
force-pushed
the
thorntonpe/lnd/IM4
branch
from
74dea15 to
5b5ad91
Compare
fmyuan
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
from
51693d1 to
051e879
Compare
fmyuan
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
from
051e879 to
857bca5
Compare
…machine with limited input data, but NOT YET fully work. Two tests are actually similary as 'elm_usrdat' test, but with 42_FLUXNETSITES and a few physiology parameters, based on Sulman et al. (2021).One of them is a short run to test codes, while another is a long run for bug-fixing heavy winter snow caused issue in arctic pft phenology. Those tests won't change simulation results until new codes and parameters are pull in.
fmyuan
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
2 times, most recently
from
3882c19 to
0939afc
Compare
bsulman
commented
Jun 21, 2024
Comment on lines
726
to
731
| !if (use_var_soil_thick .and. lev > nlevbed) then | ||
| ! this causes 2 'vst' tests failed, although it's a more reasonble fix | ||
| ! this%watsat_col(c,lev) = 0.01_r8 ! very small value for porosity of bedrock | ||
| ! xksat = 1.e-20_r8 ! cannot be zero (used below as denominator) | ||
| !endif | ||
|
|
…w a designated value
…y PFT. Now column N fixation is calculated as a weighted average over PFTs.
Add rhizome turnover
…w a designated value (modified approach)
… snow winter, snow-melt may last past the summer solstice. This likely causes no PFT onset stage even when a short non-snow season occurs. Add a flag for switching plant growth onset gdd summation end option in phenology. The switch is for extending onset stage up to start of offset in Fall, rather than to summer solstice by default.
fmyuan
force-pushed
the
ngee-arctic-IM4/pft-physiology
branch
from
0939afc to
98d2947
Compare
thorntonpe
pushed a commit
that referenced
this pull request
Aug 26, 2024
Addresses minor cleaning edits following second round of review
thorntonpe
force-pushed
the
thorntonpe/lnd/IM4
branch
from
4d622ce to
0f841e6
Compare
thorntonpe
pushed a commit
that referenced
this pull request
Sep 4, 2024
thorntonpe
pushed a commit
that referenced
this pull request
Sep 4, 2024
thorntonpe
pushed a commit
that referenced
this pull request
Sep 4, 2024
fmyuan
pushed a commit
to ORNLngee/E3SM_ORNL_IM
that referenced
this pull request
Apr 2, 2025
…eplace hard coded cycle (thorntonpe#2)
|
I'm closing this PR, since it's re-assigned to another repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PFT physiological changes on top of PFT stuff